Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth type mismatch in example project #388

Closed
ben-jacobs opened this issue Mar 25, 2021 · 3 comments · Fixed by #389 or #420
Closed

Auth type mismatch in example project #388

ben-jacobs opened this issue Mar 25, 2021 · 3 comments · Fixed by #389 or #420
Assignees
@aguacongas
Labels
bug Something isn't working
Projects
TheIdServer

Comments

@ben-jacobs
Copy link

Hi, in the server project with default configuration - authenticating in the Swagger UI (OAuth) and running examples that require authentication do not work. I believe this is because the token type for the swagger client is Jwt, whereas the rest of the example uses ReferenceTokens.

Changing the AccessTokenType to Reference fixes the issue and the API works correctly.

It'd be good if the example project could be configured to use Jwt for the API endpoint to show mixed use scenarios.

Cheers,

Ben
@ben-jacobs ben-jacobs added the bug Something isn't working label Mar 25, 2021
@aguacongas aguacongas self-assigned this Mar 25, 2021
@aguacongas aguacongas added this to To do in TheIdServer via automation Mar 25, 2021
aguacongas pushed a commit that referenced this issue Mar 25, 2021
fix: set valid audience
86191d7 
closes #388
@aguacongas aguacongas mentioned this issue Mar 25, 2021
Merged
@aguacongas aguacongas linked a pull request Mar 25, 2021 that will close this issue
fix: set valid audience #389
Merged
@aguacongas
Copy link
Member

@ben-jacobs can you test the resolution on branch fix/jwt-audience and tell me ?

@ben-jacobs
Copy link
Author

Thanks for coming back so quickly. PS Great project - setting up IdSrv can be a bit of an hassle and you've made it so much easier.

Presumably line 346 needs: return Task.CompletedTask; otherwise context.Token just gets overridden if it is actually using a OTK.

I've added that line in for now and it all appears to be working following the change.

Now all the project needs is a RavenDB backing store and a SAML/Okta provider and it'll be perfect ;)

@aguacongas
Copy link
Member

RavenDB stores are on the way feature/ravendb.
Okta is an OIDC provider so you can add it using OpenIdConnect.
Open a new enhancement if you need a SAML provider ;-)

TheIdServer automation moved this from To do to Done Mar 26, 2021
aguacongas pushed a commit that referenced this issue Mar 26, 2021
@semantic-release-bot
chore(release): 2.2.0
584c0f1 
# [2.2.0](2.1.0...2.2.0) (2021-03-26)

### Bug Fixes

* remove obsolets packages ([4429976](4429976))
* set valid audience ([86191d7](86191d7)), closes [#388](#388)
* switch to Azure package ([baf95bf](baf95bf))
* update packages ([f7ffd29](f7ffd29))
* update packages ([e1803f6](e1803f6))
* update packages ([7e5ac1e](7e5ac1e))
* update packages ([b32882d](b32882d))
* update packages ([a5e0441](a5e0441))
* update packages ([3389cfc](3389cfc))
* update packages ([ef04e93](ef04e93))
* update packages ([10b328a](10b328a))
* update packages ([41594b1](41594b1))
* update packages ([2ed76e8](2ed76e8))
* update packages ([7bcb601](7bcb601))
* update packages ([0d5fd4c](0d5fd4c))
* update packages ([e1d3a71](e1d3a71))
* update packages ([f95dc02](f95dc02))
* update packages ([4eb238a](4eb238a))
* update packages ([e6357c5](e6357c5))
* update packages ([50da361](50da361))
* update packages ([87c81c9](87c81c9))
* update packages ([6f1f2aa](6f1f2aa))
* update packages ([5032108](5032108))
* update packages ([5d13a7a](5d13a7a))
* update packages ([83aba78](83aba78))
* update packages ([5907af8](5907af8))
* update packages ([05dfb21](05dfb21))
* update packages ([6950511](6950511))
* update packages ([c912af1](c912af1))
* update packages ([153175d](153175d))
* update packages ([4ef29fb](4ef29fb))
* update packages ([2837ba1](2837ba1))
* update packages ([42258f7](42258f7))

### Features

* log user name ([32fabc2](32fabc2))
aguacongas pushed a commit that referenced this issue Mar 26, 2021
fix: set valid audience
d1bd88a 
closes #388
aguacongas pushed a commit that referenced this issue Apr 3, 2021
@semantic-release-bot
chore(release): 2.3.0
763ffb6 
# [2.3.0](2.2.0...2.3.0) (2021-04-03)

### Bug Fixes

* add role store test ([caeb0a3](caeb0a3))
* cannot add localized resource ([fd5d9f5](fd5d9f5))
* cannot set client IDP restriction ([9835e82](9835e82))
* client settings lost on save in UI ([5b83178](5b83178)), closes [#407](#407)
* request on datetime ([ff15d71](ff15d71)), closes [#399](#399)
* set valid audience ([d1bd88a](d1bd88a)), closes [#388](#388)
* storage kind filesystem typo ([8350b39](8350b39)), closes [#397](#397)
* **ravendb:** update entity remove navigation props ([6a12d69](6a12d69)), closes [#407](#407)
* update packages ([721a47b](721a47b))
* update packages ([4f78aae](4f78aae))
* update packages ([b7f8c8c](b7f8c8c))
* update packages ([de160ce](de160ce))
* update packages ([aff1c9f](aff1c9f))
* update packages ([3d4df84](3d4df84))
* update packages ([cef74c4](cef74c4))
* update packages ([23254cc](23254cc))
* update packages ([86127c0](86127c0))
* update packages ([f94b3dc](f94b3dc))
* update packages ([47ab913](47ab913))

### Features

* ravendb ([c050afa](c050afa))
* wsfederation provider ([0295b1f](0295b1f)), closes [#403](#403)
aguacongas pushed a commit that referenced this issue Apr 7, 2021
@semantic-release-bot
chore(release): 2.3.0
83ff95e 
# [2.3.0](2.2.0...2.3.0) (2021-04-07)

### Bug Fixes

* add role store test ([caeb0a3](caeb0a3))
* cannot add localized resource ([fd5d9f5](fd5d9f5))
* cannot set client IDP restriction ([9835e82](9835e82))
* client settings lost on save in UI ([5b83178](5b83178)), closes [#407](#407)
* request on datetime ([ff15d71](ff15d71)), closes [#399](#399)
* set valid audience ([d1bd88a](d1bd88a)), closes [#388](#388)
* storage kind filesystem typo ([8350b39](8350b39)), closes [#397](#397)
* **ravendb:** update entity remove navigation props ([6a12d69](6a12d69)), closes [#407](#407)
* update packages ([269e31d](269e31d))
* update packages ([d9f2cb0](d9f2cb0))
* update packages ([721a47b](721a47b))
* update packages ([4f78aae](4f78aae))
* update packages ([b7f8c8c](b7f8c8c))
* update packages ([de160ce](de160ce))
* update packages ([aff1c9f](aff1c9f))
* update packages ([3d4df84](3d4df84))
* update packages ([cef74c4](cef74c4))
* update packages ([23254cc](23254cc))
* update packages ([86127c0](86127c0))
* update packages ([f94b3dc](f94b3dc))
* update packages ([47ab913](47ab913))

### Features

* ravendb ([c050afa](c050afa))
* wsfederation provider ([0295b1f](0295b1f)), closes [#403](#403)
@aguacongas aguacongas mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aguacongas aguacongas

Labels
bug Something isn't working
Projects
TheIdServer
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set valid audience Aguafrommars/TheIdServer
chore(release): 2.3.0 Aguafrommars/TheIdServer
2 participants
@aguacongas @ben-jacobs