-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate AspNetCore.Diagnostics.HealthChecks #423
Labels
enhancement
New feature or request
Comments
I agree it's missing. Do you wanna implement it ?< |
Happy to make a start - the IdSrv4 check should be straight forward.
Database checks should be OK, just a lot of boilerplate for the different supported types. But we can maybe avoid the above by just checking the api and watching for a specific exception type (does it throw a consistent exception if the dB is unavailable when the api is called?) The auth to call the APIs in this case will be the tricky bit (in theory the user can delete the client in the ui and then health checks would fail, even though they'd actually be working fine for the user auth.
Health checks for external providers is probably the most complex and arguably less relevant to Theidserver health (can't guarantee network availability for oauth dance at the user end etc - most things are out of your control).
Probably a week or so before I start, been sick and a few things to catch up on first.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Olivier Lefebvre ***@***.***>
Sent: Friday, April 9, 2021 10:47:34 PM
To: Aguafrommars/TheIdServer ***@***.***>
Cc: Ben Jacobs ***@***.***>; Author ***@***.***>
Subject: Re: [Aguafrommars/TheIdServer] Incorporate AspNetCore.Diagnostics.HealthChecks (#423)
I agree it's missing. Do you wanna implement it ?<
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#423 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AENPI64D4V3K44UWI2U5LALTH3465ANCNFSM42U5OB7A>.
|
This was referenced Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What are you thoughts on incorporating AspNetCore.Diagnostics.HealthChecks into Aguacongas.TheIdServer?
In the first instance this could be as simple as adding a healthcheck to ensure the IdSrv discovery endpoints are available - with enhancements covering the DB providers etc if necessary. In this most basic configuration, it shouldn't add more than a few lines of configuration code - there's even an IdentityServer healthcheck already available.
Given that I think the project is very conducive to being part of a microservices architecture, the healthchecks would allow for common orchestration tools to check the health status.
The text was updated successfully, but these errors were encountered: