Skip to content

Commit

Permalink
5.0.11.90136
Browse files Browse the repository at this point in the history
  • Loading branch information
@Ahli
Ahli committed Apr 20, 2023
1 parent 9e33ce5 commit f293611
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 6 deletions.
8 changes: 6 additions & 2 deletions mods/voidmulti.sc2mod/base.sc2data/gamedata/actordata.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1652,13 +1652,15 @@
<IconArcLength value="3.250000"/>
</CActorRange>
<CActorSound id="RavenScramblerMissileImpactSound" parent="SoundOneShot">
<On Terms="Effect.RavenScramblerMissileAB.Start; At Target" Send="Create"/>
<On Terms="Effect.RavenScramblerMissileABswitch.Start; At Target" Send="Create"/>

This comment has been minimized.

Sign in to view

Copy link
@Ahli

Ahli Apr 20, 2023

Author Owner
  • currently breaks the impact sound because the effect is not used/existing
<Host Subject="_Selectable"/>
<Sound value="SkyTank_BarrageMissile_Impact"/>
</CActorSound>
<CActorModel id="RavenScramblerMissileBehavior" parent="ModelAnimationStyleContinuous">
<On Terms="Behavior.RavenScramblerMissile.On" Send="Create"/>
<On Terms="Behavior.RavenScramblerMissile.Off" Send="AnimBracketStop BSD"/>
<On Terms="Behavior.RavenScramblerMissileCarrier.On" Send="Create"/>
<On Terms="Behavior.RavenScramblerMissileCarrier.Off" Send="AnimBracketStop BSD"/>
<On Terms="ActorCreation; ValidateUnit IsColossus" Send="SetScale 1.000000,1.000000,1.500000"/>
<On Terms="ActorCreation; ValidateUnit IsCarrier" Send="SetScale 0.750000"/>
<On Terms="ActorCreation; ValidateUnit IsTempest" Send="SetScale 0.850000"/>
Expand All @@ -1683,7 +1685,7 @@
</CActorAction>
<CActorModel id="RavenScramblerMissileImpact" parent="GenericAttackImpactModel">
<HostSiteOps Ops="SOpAttachCenter SOpForwardLaunchGuide SOp2DRotation" HoldRotation="1"/>
<On Terms="Effect.RavenScramblerMissileAB.Start; At Target" Send="Create"/>
<On Terms="Effect.RavenScramblerMissileABswitch.Start; At Target" Send="Create"/>

This comment has been minimized.

Sign in to view

Copy link
@Ahli

Ahli Apr 20, 2023

Author Owner
  • currently breaks the impact model because the effect is not used/existing
<!--On Terms="ActorCreation" Send="SetScale 2.500000"/-->
<Model value="RavenScramblerMissileImpact"/>
<AutoScaleFactor value="1.000000"/>
Expand All @@ -1692,6 +1694,8 @@
<CActorSound id="RavenScramblerMissileLoopSound" parent="SoundContinuous">
<On Terms="Behavior.RavenScramblerMissile.On" Send="Create"/>
<On Terms="Behavior.RavenScramblerMissile.Off" Send="Destroy"/>
<On Terms="Behavior.RavenScramblerMissileCarrier.On" Send="Create"/>
<On Terms="Behavior.RavenScramblerMissileCarrier.Off" Send="Destroy"/>
<Sound value="Raven_ScramblerMissileLoop"/>
</CActorSound>
<CActorUnit id="RavenRepairDrone" parent="GenericUnitStandard" unitName="RavenRepairDrone">
Expand Down
14 changes: 14 additions & 0 deletions mods/voidmulti.sc2mod/base.sc2data/gamedata/behaviordata.xml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<Catalog>
<CEffectApplyBehavior id="RavenScramblerMissileABcarrier">
<EditorCategories value="Race:Terran"/>
<Behavior value="RavenScramblerMissileCarrier"/>
</CEffectApplyBehavior>
<CEffectSwitch id="RavenScramblerMissileABswitch">
<EditorCategories value="Race:Terran"/>
<CaseArray Validator="IsCarrier" Effect="RavenScramblerMissileABcarrier"/>
<CaseDefault value="RavenScramblerMissileAB"/>
</CEffectSwitch>

This comment has been minimized.

Sign in to view

Copy link
@Ahli

Ahli Apr 20, 2023 •
edited

Author Owner

This needs to be in effectdata.xml, not behaviordata.xml.
Also, it is not editing RavenScramblerMissileLM to execute RavenScramblerMissileABswitch on impact instead of RavenScramblerMissileAB.

So, this is missing and the entire block needs to be put into effectdata.xml:

    <CEffectLaunchMissile id="RavenScramblerMissileLM">
        <FinishEffect value="RavenScramblerMissileABswitch"/>
    </CEffectLaunchMissile>
<CBehaviorBuff id="AddonIsWorking">
<BehaviorFlags index="Permanent" value="1"/>
<InfoFlags index="Hidden" value="1"/>
Expand Down Expand Up @@ -702,6 +711,11 @@
<DisableValidatorArray value="TargetNotTacticalJumping"/>
<BuffFlags index="UpdateDurationWhileDisabled" value="1"/>
</CBehaviorBuff>
<CBehaviorBuff id="RavenScramblerMissileCarrier" parent="RavenScramblerMissile">
<Modification>
<ModifyFlags index="EnableAttack" value="0"/>

This comment has been minimized.

Sign in to view

Copy link
@Ahli

Ahli Apr 20, 2023 •
edited

Author Owner
  • Interference Matrix disables attack ability, but only for the Carrier to fix its Interceptors often not returning to the Carrier
</Modification>
</CBehaviorBuff>
<CBehaviorBuff id="RavenRepairDroneTimedLife" parent="TimedLife">
<EditorCategories value="Race:Terran,AbilityorEffectType:Units"/>
<DisplayDuration index="Enemy" value="1"/>
Expand Down
4 changes: 0 additions & 4 deletions mods/voidmulti.sc2mod/base.sc2data/gamedata/upgradedata.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@
<EffectArray index="1" Value="10.000000"/>
</CUpgrade>
<CUpgrade id="ExtendedThermalLance">
<EffectArray index="0" Value="2"/>
<EffectArray index="1" Value="2"/>

This comment has been minimized.

Sign in to view

Copy link
@Ahli

Ahli Apr 20, 2023

Author Owner
  • Extended Thermal Lance range bonus increased from 2 to 3
<EffectArray Reference="Weapon,ThermalLances,MinScanRange" Value="2"/>

This comment has been minimized.

Sign in to view

Copy link
@Ahli

Ahli Apr 20, 2023

Author Owner
  • Extended Thermal Lance min scan range decreased from 9.5 to 10 eliminating the 0.5 offset units usually have
<EffectArray Reference="Validator,ColossusAttackDamageMaxRange,Range" Value="2"/>

This comment has been minimized.

Sign in to view

Copy link
@Ahli

Ahli Apr 20, 2023

Author Owner

clean up. Had no effect anymore since range uses attack target point for distance calculation instead of source point
<ScoreAmount value="300"/>
</CUpgrade>
<CUpgrade id="GhostMoebiusReactor">
Expand Down

2 comments on commit f293611

@Ahli
Copy link
Owner Author

@Ahli Ahli commented on f293611 Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ These changes are only in the game client, not in your actual games!

The game streams changes from an online depot as well. I've been told that these changes were never released there. Blizzard seems to have noticed their mistake early enough to not disrupt online gameplay.

However, when you test things in the editor using VoidMulti, you will notice these changes, as I did.

@Ahli
Copy link
Owner Author

@Ahli Ahli commented on f293611 Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes went live on 2023-07-11 00:13 according to https://sc2arcade.com/map/2/185978/versions

Please sign in to comment.