Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deploy branch #7

Merged
merged 3 commits into from
Apr 13, 2020

Conversation

yacafx
Copy link
Contributor

@yacafx yacafx commented Apr 13, 2020

When the method deployToGithub is executed, the deploy_branch was never used, instead, the hardcoded gh-pages value was used.

Here I update the deployConfig object and add the deployBranch property.

@yacafx
Copy link
Contributor Author

yacafx commented Apr 13, 2020

@AhsanAyaz I'm not pretty sure if the Github Access token needs to be on your repo or in my fork... I'm already added on my repo secrets but still no work... U have any idea?

Copy link
Owner

@AhsanAyaz AhsanAyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yacafx. Thanks for finding the issue and raising a PR :)
Looks good to me 👍
And yes, it requires a token in your fork to work well I guess. Otherwise, when I merge, this should automagically pass it.
Will do so and will release a new version.

@AhsanAyaz AhsanAyaz merged commit 9a54b75 into AhsanAyaz:master Apr 13, 2020
@AhsanAyaz
Copy link
Owner

@yacafx Here's the new release with PR merged:
https://github.com/AhsanAyaz/angular-deploy-gh-pages-actions/releases/tag/v1.2.0

@yacafx
Copy link
Contributor Author

yacafx commented Apr 20, 2020

Thank u @AhsanAyaz ! Happy to collaborate! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants