Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(twofactor): More customization and extended functioniality #3

Merged
merged 19 commits into from
May 9, 2023
Merged

feat(twofactor): More customization and extended functioniality #3

merged 19 commits into from
May 9, 2023

Conversation

TheXorog
Copy link
Member

@TheXorog TheXorog commented May 9, 2023 •
edited
Loading

Description

This touches in the TwoFactor Extension to allow more use-cases, more ways a developer can interact with the result after authentication has taken place and more customization.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with Makoto.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@TheXorog TheXorog changed the title feat(twofactor): More customizability feat(twofactor): More customization and extended functioniality May 9, 2023
@TheXorog TheXorog marked this pull request as ready for review May 9, 2023 17:30
@TheXorog TheXorog requested review from a team, NyuwBot and Lulalaby as code owners May 9, 2023 17:30
@TheXorog TheXorog requested a review from Saalvage May 9, 2023 17:30
TheXorog and others added 4 commits May 9, 2023 19:57
@TheXorog @Lulalaby
Update DisCatSharp.Extensions.Docs/articles/extensions/twofactor_comm…
666990c 
…ands/intro.md

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Signed-off-by: Mira <xorog@outlook.de>
@TheXorog @Lulalaby
Update DisCatSharp.Extensions.Docs/articles/extensions/twofactor_comm…
8959a32 
…ands/intro.md

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Signed-off-by: Mira <xorog@outlook.de>
@TheXorog
Update intro.md
f2bd243
@TheXorog
[ci skip]
642cf49
@Lulalaby Lulalaby merged commit 0b5778a into main May 9, 2023
@Lulalaby Lulalaby deleted the extended-tfa branch May 9, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@NyuwBot NyuwBot Awaiting requested review from NyuwBot NyuwBot is a code owner

@Saalvage Saalvage Awaiting requested review from Saalvage Saalvage is a code owner automatically assigned from Aiko-IT-Systems/discatsharp

Assignees

@Lulalaby Lulalaby

@TheXorog TheXorog

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheXorog @Lulalaby