Code cleaning #18
Merged
Code cleaning #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is only needed for IP fragmentation and we don't support it for now. Even if IP fragmentation was supported, reading RFC6864 I understand we should not modify this field. More information about that: https://crnetpackets.com/2015/08/29/a-short-story-about-the-ip-id-field/
oliwer
approved these changes
Aug 22, 2019
| @@ -123,7 +118,7 @@ class Data(ct.Structure): | |||
|
|
|||
| # Compile & attach bpf program | |||
| print("\nCompiling & attaching bpf code ...") | |||
| b = BPF(src_file ="ulb.c", debug=debug, cflags=["-Wno-incompatible-pointer-types", "-Wno-compare-distinct-pointer-types"]) | |||
| b = BPF(src_file ="ulb.c", debug=debug) | |||
There was a problem hiding this comment.
Feature request: let the user to specify cflags using a CFLAGS environment variable.
There was a problem hiding this comment.
I create a new issue about that : #19.
Do not hesitate to create new issue for feature request.
This was referenced Aug 22, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit names/comments for details.
I advice to review commit by commit.
(This tasks is related to #6)