Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Adding 'horizontal' and 'vertical' to the types of gaps #210

Closed
wants to merge 1 commit into from

Conversation

cameronleger
Copy link
Contributor

Using e2f1093 as a reference
README updates for new configuration options

Adding 'horizontal' and 'vertical' to the types of gaps
README updates for new configuration options
@Airblader
Copy link
Owner

Thanks! At first glance this looks really good to me. I'll need to take a more detailed look at it, but I think complexity-wise I'm happy to merge such a change.

@Airblader
Copy link
Owner

The changes look absolutely fine to me. I'll write a comment on the issue.

@A-Manning
Copy link

It would be nice to have more fine-grained control here, eg. upper, lower, left, right gaps.

@op8867555
Copy link
Contributor

I've been running this branch for roughly a week and no problem happens so far. I agree with @A-Manning, should we discuss that back in #54?

@Airblader
Copy link
Owner

When doin so, please don't just say »it would be nice«, but given an actual usecase for it. If asking users randomly, they'll always prefer moar optionz, but that's not how we build i3.

@A-Manning
Copy link

@Airblader I can see several use cases for this. Personally I have a transparent i3bar, which makes the gaps appear larger on one side. I'd like to be able to reduce the gaps on that side to even things out.

Another use case would be if a user wishes to run a transparent dmenu2, or transparent i3bar in hide mode; It's impractical to use transparency, since these will render on top of other windows. If we could adjust gaps on a particular side, then one could increase the gap size on whichever side they appear when showing them, and revert when hiding.

@cameronleger
Copy link
Contributor Author

cameronleger commented Apr 25, 2018 via email

@Airblader
Copy link
Owner

Closing because we're going with #211

@Airblader Airblader closed this Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants