-
Notifications
You must be signed in to change notification settings - Fork 324
Adding 'horizontal' and 'vertical' to the types of gaps #210
Conversation
Adding 'horizontal' and 'vertical' to the types of gaps README updates for new configuration options
Thanks! At first glance this looks really good to me. I'll need to take a more detailed look at it, but I think complexity-wise I'm happy to merge such a change. |
The changes look absolutely fine to me. I'll write a comment on the issue. |
It would be nice to have more fine-grained control here, eg. upper, lower, left, right gaps. |
I've been running this branch for roughly a week and no problem happens so far. I agree with @A-Manning, should we discuss that back in #54? |
When doin so, please don't just say »it would be nice«, but given an actual usecase for it. If asking users randomly, they'll always prefer moar optionz, but that's not how we build i3. |
@Airblader I can see several use cases for this. Personally I have a transparent i3bar, which makes the gaps appear larger on one side. I'd like to be able to reduce the gaps on that side to even things out. Another use case would be if a user wishes to run a transparent dmenu2, or transparent i3bar in hide mode; It's impractical to use transparency, since these will render on top of other windows. If we could adjust gaps on a particular side, then one could increase the gap size on whichever side they appear when showing them, and revert when hiding. |
Both cases seem like actual problems to solve, but I'm not convinced this is the correct way to handle them. IMO it requires extending the bar functionality to place a window on a side and change the overall container based on that window. For example, running i3bar or polybar results in the desired behavior: everything is adjusted automatically and the user didn't have to think about it.
Users seeing specific gaps manually to imitate this is hacky.
…On Apr 25, 2018, 09:47, at 09:47, A L Manning ***@***.***> wrote:
@Airblader I can see several use cases for this. Personally I have a
transparent i3bar, which makes the gaps appear larger on one side. I'd
like to be able to reduce the gaps on that side to even things out.
Another use case would be if a user wishes to run a transparent dmenu2,
or transparent i3bar in hide mode; It's impractical to use
transparency, since these will render on top of other windows. If we
could adjust gaps on a particular side, then one could increase the gap
size on whichever side they appear when showing them, and revert when
hiding.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#210 (comment)
|
Closing because we're going with #211 |
Using e2f1093 as a reference
README updates for new configuration options