Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support for HTTP request API #1177

Open
SpicerSolutions opened this issue Sep 12, 2020 · 4 comments
Open

HTTPS support for HTTP request API #1177

SpicerSolutions opened this issue Sep 12, 2020 · 4 comments
Labels
enhancement workaround The issue contains a workaround

Comments

@SpicerSolutions
Copy link

Is HTTPS likely to be support on the HTTP request endpoint?

I appreciate this might be difficult for people with expiring SSL certificates.

@Aircoookie
Copy link
Owner

Hi!
This is not likely/almost impossible to implement on ESP8266 due to insufficient memory.
On the ESP32 it is a different story, HTTPS support is easily possible. Still we would need to figure out how to add a certificate that is ideally both not self-signed (so that it is trusted by browsers), but that could not be circumvented by the private key becoming public due to the open source of WLED. This would likely require users to generate/install their own certificates for true security, but it's definitely something I want to look into!

@pbolduc
Copy link
Contributor

pbolduc commented Sep 12, 2020

@SpicerSolutions You can hear Unexpected Maker talk about the issues with https on this video: https://youtu.be/A4Hzz84HuNY?t=733 The issue is around the certificates consuming too much RAM. Though, in the video, I am not 100% clear if he is talking about inbound or outbound connections. If I wanted to secure my WLED on my network, I would probably use a reverse proxy and firewall rules.

@Fonta
Copy link

Fonta commented Jan 12, 2023

Could use a self-signed certificate by default. In the config you could then replace it with your own. That's how most devices work.

@blazoncek
Copy link
Collaborator

This can be supported using reverse proxy which will handle HTTPS (and WSS) with recent modifications in 0.14.0-b3+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement workaround The issue contains a workaround
Projects
None yet
Development

No branches or pull requests

5 participants