Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 3 #3238

Merged
merged 23 commits into from Jun 13, 2023
Merged

Beta 3 #3238

merged 23 commits into from Jun 13, 2023

Conversation

blazoncek
Copy link
Collaborator

@blazoncek blazoncek commented Jun 8, 2023

Adds the following:

Copy link
Owner

@Aircoookie Aircoookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge :)

NeoGammaWLEDMethod might be nice to have as an option, but right now I don't see any benefit to calling it from NPB. The current approach of pre-calculating gamma is optimal performance wise and has no drawbacks in my opinion.

@blazoncek
Copy link
Collaborator Author

NeoGammaWLEDMethod might be nice to have as an option, but right now I don't see any benefit to calling it from NPB.

Indeed. That is why I only created class and added comment into bus_wrapper.h. The truth is @Makuna created similar class after I suggested it to him.
Makuna/NeoPixelBus#644

@blazoncek blazoncek merged commit 670461c into main Jun 13, 2023
20 checks passed
@blazoncek blazoncek deleted the beta-3 branch June 13, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON APIs assigned to buttons , e.g {"ps":"1~4~"} Settings page not working on reverse proxy
2 participants