Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all segment options are synced using UDP sync #3487

Closed
1 task done
DarthWeber opened this issue Oct 26, 2023 · 3 comments
Closed
1 task done

Not all segment options are synced using UDP sync #3487

DarthWeber opened this issue Oct 26, 2023 · 3 comments
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master major This is a non-trivial major feature and will take some time to implement

Comments

@DarthWeber
Copy link

What happened?

e.g. Bouncing ball works fine also on 2d matrix setups. But when synced to another matrix, the slave changes to bouncing ball too, but it looks messed up like the orientation of the matrix is suddenly destroyed or something like that. To reproduce:

Both instances has no problem in presenting bouncing balls independently without sync.

The effects like meatballs doesn't show this issue.

To Reproduce Bug

Master wled 14.0 with sync bouncing balls on a matrix 16wh60
Slave wled 14.0 also matrix, but different dimensions 6w60h and other orientaton

Expected Behavior

Correct sync of 1d effects on 2d effects ins sync mode

Install Method

Self-Compiled

What version of WLED?

0.14.0

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No one

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@DarthWeber DarthWeber added the bug label Oct 26, 2023
@blazoncek
Copy link
Collaborator

Synced how? UDP sync? DDP?

@DarthWeber
Copy link
Author

By UDP

@blazoncek
Copy link
Collaborator

UDP sync (even with options enabled) will not sync every segment option, including sound simulation and 1D-2D mapping.
1D-2D mapping is required for correct 1D effect behaviour.

This is a shortcoming of UDP sync as only 1 byte is reserved for segment options (whereas it requires full 16 bit).

@blazoncek blazoncek changed the title Messing up some 1d effects in 2d matrix sync received Not all segment options are synced using UDP sync Oct 26, 2023
@blazoncek blazoncek added confirmed The bug is reproducable and confirmed major This is a non-trivial major feature and will take some time to implement labels Oct 26, 2023
blazoncek added a commit that referenced this issue Oct 27, 2023
blazoncek added a commit that referenced this issue Oct 27, 2023
@blazoncek blazoncek added the fixed in source This issue is unsolved in the latest release but fixed in master label Oct 27, 2023
softhack007 pushed a commit to MoonModules/WLED that referenced this issue Nov 11, 2023
@softhack007 softhack007 added this to the 0.14.1 candidate milestone Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master major This is a non-trivial major feature and will take some time to implement
Projects
None yet
Development

No branches or pull requests

3 participants