Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist stuck on first Preset #3843

Closed
1 task done
garnbleiche opened this issue Mar 22, 2024 · 1 comment
Closed
1 task done

Playlist stuck on first Preset #3843

garnbleiche opened this issue Mar 22, 2024 · 1 comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master

Comments

@garnbleiche
Copy link

garnbleiche commented Mar 22, 2024

What happened?

Playlist loads only first Preset and gets stucked.

To Reproduce Bug

Create a playlist with with some entrys and start the playlist.

Expected Behavior

Play the entire playlist without being stuck on the first entry.

Install Method

Binary from WLED.me

What version of WLED?

WLED 0.15.0-b1 (build 2403190)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Output from debug build

Playlist works in version WLED 0.14.2-b2 !

Serial Output from Debug Build WLED 0.15.0-b1 (playlist stuck on first entry):

Applying preset: 5
Playlist unloaded.
Playlist loaded.
JSON buffer released. (9)
Loop took 31ms.
Usermods took 0ms.
Strip took 29ms.
Playlist unloaded.
Request to apply preset: 2
JSON buffer locked. (9)
Applying preset: 2
JSON buffer released. (9)
JSON buffer locked. (12)
JSON buffer size: 2302 for WS request (1270).
heap 190596
Sending WS data to multiple clients.
JSON buffer released. (12)
Loop took 47ms.
Usermods took 0ms.
Strip took 44ms.

Serial Output from Debug Build WLED 0.14.2-b2 (playlist works):

Applying preset: 5
Playlist unloaded.
Playlist loaded.
JSON buffer released. (9)
Request to apply preset: 2
JSON buffer locked. (9)
Applying preset: 2
JSON buffer released. (9)
JSON buffer locked. (12)
JSON buffer size: 2168 for WS request (1195).
heap 202664
Sending WS data to multiple clients.
JSON buffer released. (12)
Loop took 45ms.
Usermods took 0ms.
Strip took 43ms.
Request to apply preset: 4
JSON buffer locked. (9)
Applying preset: 4
JSON buffer released. (9)
JSON buffer locked. (12)
JSON buffer size: 2166 for WS request (1194).
heap 202668
Sending WS data to multiple clients.
JSON buffer released. (12)
Loop took 47ms.
Usermods took 0ms.
Strip took 46ms.
Request to apply preset: 3
JSON buffer locked. (9)
Applying preset: 3
JSON buffer released. (9)
JSON buffer locked. (12)
JSON buffer size: 2170 for WS request (1199).
heap 202668
Sending WS data to multiple clients.
JSON buffer released. (12)
Loop took 46ms.
Usermods took 0ms.
Strip took 45ms.
Playlist unloaded.
Request to apply preset: 4
JSON buffer locked. (9)
Applying preset: 4
JSON buffer released. (9)
JSON buffer locked. (12)
JSON buffer size: 2166 for WS request (1195).
heap 202708
Sending WS data to multiple clients.
JSON buffer released. (12)
Loop took 46ms.
Usermods took 0ms.
Strip took 45ms.

It seems that the bug is in the presets.cpp (unloadPlaylist):

bool applyPreset(byte index, byte callMode)
{
  unloadPlaylist(); // applying a preset unloads the playlist (#3827)
  DEBUG_PRINT(F("Request to apply preset: "));
  DEBUG_PRINTLN(index);
  presetToApply = index;
  callModeToApply = callMode;
  return true;
}
@blazoncek blazoncek added confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master labels Mar 22, 2024
blazoncek added a commit that referenced this issue Mar 22, 2024
- #3843
- #3844
- network scan on new install
- misc optimization
@blazoncek
Copy link
Collaborator

Will be available in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master
Projects
None yet
Development

No branches or pull requests

2 participants