Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usermod Battery 🔋 Added Support for different battery types, Optimized file structure #3003

Merged
merged 22 commits into from
May 6, 2024
Merged

Usermod Battery 🔋 Added Support for different battery types, Optimized file structure #3003

merged 22 commits into from
May 6, 2024

Conversation

itCarl
Copy link
Contributor

@itCarl itCarl commented Jan 5, 2023

Currently adding new features / restructurings Things.
The main purpose for this PR is so that can @softhack007 can see what i already made.

@softhack007 softhack007 added the usermod usermod related label Jan 7, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

Hey! This issue has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs.
Thank you for using WLED!

@stale stale bot added the stale This issue will be closed soon because of prolonged inactivity label Jun 18, 2023
@blazoncek blazoncek added the keep This issue will never become stale/closed automatically label Jun 18, 2023
@stale stale bot removed the stale This issue will be closed soon because of prolonged inactivity label Jun 18, 2023
@itCarl
Copy link
Contributor Author

itCarl commented Jul 14, 2023

Hello there,
since I finished my studies in university (since the beginning of the year) and now work full time in the healthcare software development area I hardly find time to bring 'private' projects forward.
I hope you have a little patience until I find time to finish this PR.

Greetings from Germany ❤️

@softhack007 softhack007 added this to the 0.14.1 candidate milestone Sep 5, 2023
@itCarl
Copy link
Contributor Author

itCarl commented Jan 31, 2024

Hi 👋,
I need some help / suggestions on the current structure of this usermod. I don't know if I still like the "one class for each battery type" approach. My original thought was to make it more flexible and open to a wider variety of battery types by using a module like structure.

@itCarl itCarl marked this pull request as ready for review April 30, 2024 13:04
@blazoncek
Copy link
Collaborator

Please rebase for 0_15 branch 1st.

@itCarl itCarl changed the base branch from main to 0_15 April 30, 2024 15:12
@blazoncek
Copy link
Collaborator

Could you change classes Lion, Lipo and Unknown to something related to battery usermod, like LionBattery for example.
This will prevent eventual future conflicts.

Since I do not own any battery powered device and cannot test I'll trust you have done extensive testing... 😄

@blazoncek blazoncek mentioned this pull request May 6, 2024
Closed
@blazoncek
Copy link
Collaborator

Thank you. Is it now ready for merge?

@itCarl
Copy link
Contributor Author

itCarl commented May 6, 2024

yes, it is now ready for merging.

@blazoncek blazoncek merged commit 47e1cbd into Aircoookie:0_15 May 6, 2024
18 checks passed
adamsthws added a commit to adamsthws/WLED that referenced this pull request May 9, 2024
@adamsthws
Rebased for 0_15
01e6377 
Rebased the updated Battery usermod for 0_15.

Added a constant so the delay can be modified via my_config.h.

Small adjustments have been made to make the PR compatible again after the recent restructuring in this PR: (Aircoookie#3003).

Thankyou!
adamsthws added a commit to adamsthws/WLED that referenced this pull request May 9, 2024
@adamsthws
Update Usermod: Battery
bc5aadf 
Issue:
When taking the initial voltage reading after first powering on, voltage hasn't had chance to stabilize so the reading can be inaccurate, which in turn may incorrectly trigger the low-power preset. (Manifests when the user has selected a low read interval and/or is using a capacitor).

Resolution:
A non-blocking, fixed 10 second delay has been added to the initial voltage reading to give the voltage time to stabilize.

This is a reworked version of the (now closed) PR here:
Aircoookie#3959

- Rebased the update for 0_15.

- Added a constant so the delay can be modified via my_config.h.

- Small adjustments to make the PR compatible again after the recent restructuring in this PR: (Aircoookie#3003).

Thankyou!
@adamsthws adamsthws mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keep This issue will never become stale/closed automatically usermod usermod related
Projects
None yet
Milestone
0.15.0-alpha candidate
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itCarl @blazoncek @softhack007