Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show current local time in info page ⏲️ #3351

Merged
merged 6 commits into from
Sep 2, 2023

Conversation

PSandro
Copy link
Contributor

@PSandro PSandro commented Aug 29, 2023

resolves #3284

Adding the current local time to the info page ⏲️ . This allows to check the device time quickly without having to navigate to the Time & Macros Settings page 🎉

Best,
Sandro

@blazoncek
Copy link
Collaborator

blazoncek commented Aug 30, 2023

Please remove all (.h) files that have no connection with the PR.
This includes all html_*.h except html_ui.h and html_simple.h

Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.
I would prefer shorter string instead of "Current local time". Perhaps just "Time"?

@PSandro
Copy link
Contributor Author

PSandro commented Aug 30, 2023

All good. I would prefer shorter string instead of "Current local time". Perhaps just "Time"?

I would also prefer 'Time'. My initial idea was to keep it consistent with the 'Time & Macros' page. But if that is not important, then let's change it to 'Time' 👍

@PSandro
Copy link
Contributor Author

PSandro commented Aug 30, 2023

image
This is how it looks now

@softhack007
Copy link
Collaborator

Change looks ok for me, too. Would agree to merge.

@blazoncek blazoncek merged commit 25553a2 into Aircoookie:main Sep 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add device current time to Info page
3 participants