Fix ES8388Source & ES7243 initialization.

[christianpatterson]

Update ES8388Source::initialize and ES7243::initialize method signatures to match I2SSource::initialize so that when initialize is called on a AudioSource pointer the child class's method is used.

[blazoncek]

IMO it should be the other way around.
You should remove two obsolete parameters in I2SSource.
Looks like we forgot to do that.

[softhack007]

You should remove two obsolete parameters in I2SSource.
Looks like we forgot to do that.

I agree with @blazoncek. The only place where this specific initialize is called, is here (and likewise in case 2 for es7243)

WLED/usermods/audioreactive/audio_reactive.h

Lines 1164 to 1169 in 527e3d6

	case 6:
	DEBUGSR_PRINTLN(F("AR: ES8388 Source"));
	audioSource = new ES8388Source(SAMPLE_RATE, BLOCK_SIZE);
	delay(100);
	if (audioSource) audioSource->initialize(i2swsPin, i2ssdPin, i2sckPin, mclkPin);
	break;

The two extra parameters were meant for SDA and SDL (I2C) but with the change to only use global I2C pins, these are not needed any more.

[christianpatterson]

Updated, but I was only able to test it with ES8388 and Generic I2S since that's all the hardware I have.

[blazoncek]

I think this is also a problem @netmindz was facing when moving upstream code to MM.

BTW Nobody seems to have ES7243 any more. Perhaps @FHeilmann?

[netmindz]

Move was actually in the other direction. Removal of I2C from source broke MM as I think the global I2C hadn't actually been merged into MM at that stage

[softhack007]

thanks for this PR :-) well spotted 👍