Fix settings caching on some browsers #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding a random string to the path of the js file every time, we make sure to never hit the browser cache.
By setting the response header "Cache-Control" to "no-store" and setting "Expires" to 0, we make sure the browsers and place calling this never store it in cache.
|
I would only approve the second even though we may never have exact control over browser caching on a particular Android/iOS/PC device. |
|
@Moustachauve can you revert HTML changes and only do backend change? |
|
Unless @softhack007 has a strong opinion, I will revert the HTML changes tonight. |
Fine for me 👍 |
This reverts commit 51dfa9a.
|
Revert for the html changes is done. |
softhack007
pushed a commit
to MoonModules/WLED
that referenced
this pull request
Nov 27, 2023
Fix settings caching on some browsers
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some browser, especially Android webview, have more aggressive caching strategies and might sometimes cache the response of the settings JS.
This implements two strategy, one in the back-end and one in the front-end. Two might be overkill, so we could keep a single one if needed.
Front-end strategy to prevent caching
By adding a random string to the path of the js file every time, we make sure to never hit the browser cache.
Back-end strategy to prevent caching
By setting the response header "Cache-Control" to "no-store" and setting "Expires" to 0, we make sure the browsers and place calling this never store it in cache.