Better sorting and naming of static palettes in the Custom Palette Editor #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazoncek
reviewed
Jan 12, 2024
| @@ -520,8 +521,10 @@ <h1 style="display: flex; align-items: center;"> | |||
| if (hst.length > 0 ) { | |||
| try { | |||
| var arr = []; | |||
| const response = await fetch('http://'+hst+'/json/info'); | |||
| const json = await response.json(); | |||
| const responseInfo = await fetch('http://'+hst+'/json/info'); | |||
There was a problem hiding this comment.
Perhaps also use getURL() logic from index.js which will work behind reverse proxy.
There was a problem hiding this comment.
I did it like it was done before. But it you would prefer it we could also use getURL().
There was a problem hiding this comment.
The only problem I see is that if we do this we have to copy the code from index.js to cpal.htm and then we have created duplicate code again. We could wait with this until we have a global.js file that contains functions like getURL() that are used on every page, so we do not have to maintain the duplicate code. But I'll let you decide. Should I just copy the code now, or should we wait until we have a global.js file?
softhack007
pushed a commit
to MoonModules/WLED
that referenced
this pull request
Jan 15, 2024
Better sorting and naming of static palettes in the Custom Palette Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alphabetically sorts the static palettes of the Custom Palette Editor.
Also the hover text was changed from
Copy slot [id] palette to editortoCopy [name] palette to editor.Now it should be easier to get the correct palette for editing.
This should be a fix for the bug that was reported in the discord #beta-testing channel.