Enabled some audioreactive effects for single pixel strips/segments #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is ok, but let's wait what @softhack007 says. |
|
@softhack007 could you look into this, please. IMO the changes are benign and I'd like to include them in b3 release scheduled for next week. |
I'm on it 馃槂 overall looks good, thanks @gaaat98 for doing the "zero D" checks. I'll try them on my own setup in next days, plus i'll review the code to be sure there is no danger of running into invalid pointers or div/0 situations. |
softhack007
requested changes
May 6, 2024
softhack007
pushed a commit
to MoonModules/WLED
that referenced
this pull request
May 7, 2024
Enabled some audioreactive effects for single pixel strips/segments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Solution" to #3937
Enabled Juggles, Noisefire, Plasmoid, DJ Lights, Freqmatrix, Freqwave, Noisemove, Rocktaves, and Waterfall effects (I chose the ones that looked the best to me) to be selected for single pixel segments/LED strips.
Some effects (noisefire, plasmoid) needed just the metadata to be updated, the others also needed the
if (SEGLEN == 1) return mode_static();check to be disabled, I verified that removing the check does not create problems in the functions (hopefully 馃槄, see comments in code).