Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usermod BME68X Sensor Implementation rebased for WLED 0.15 #3994

Merged
merged 8 commits into from
May 21, 2024

Conversation

gsieben
Copy link

@gsieben gsieben commented May 20, 2024

Here is again my pull request for the user mod "BMW68X" sensor implementation. Now as requested for wled version 0.15.

Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Well written and complete. But...

There's a code that does not belong in a usermod PR. You might re-open the original PR for that instead.

wled00/wled.h Outdated
@@ -213,6 +213,10 @@ using PSRAMDynamicJsonDocument = BasicJsonDocument<PSRAM_Allocator>;
#define WLED_AP_PASS DEFAULT_AP_PASS
#endif

#ifndef OTA_PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha. 😀
Sneaky.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Sorry about that. Somehow I'm too dumb to make various pull requests. :-D

Accidentally included changes removed.
@blazoncek blazoncek merged commit 9f581c6 into Aircoookie:0_15 May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants