-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usermod BME68X Sensor Implementation rebased for WLED 0.15 #3994
Usermod BME68X Sensor Implementation rebased for WLED 0.15 #3994
Conversation
OTA_PASS
…n WLED 0.15" This reverts commit faa2fba.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Well written and complete. But...
There's a code that does not belong in a usermod PR. You might re-open the original PR for that instead.
wled00/wled.h
Outdated
@@ -213,6 +213,10 @@ using PSRAMDynamicJsonDocument = BasicJsonDocument<PSRAM_Allocator>; | |||
#define WLED_AP_PASS DEFAULT_AP_PASS | |||
#endif | |||
|
|||
#ifndef OTA_PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hahaha. 😀
Sneaky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Sorry about that. Somehow I'm too dumb to make various pull requests. :-D
Accidentally included changes removed.
One error message was in German
Here is again my pull request for the user mod "BMW68X" sensor implementation. Now as requested for wled version 0.15.