Update never terminate logic #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
update-never-terminate-logic
branch
4 times, most recently
from
696ba5b
to
a30ab19
Compare
jlprat
approved these changes
Mar 25, 2022
mdedetrich
force-pushed
the
update-never-terminate-logic
branch
2 times, most recently
from
3a3f474
to
aac9a46
Compare
jlprat
approved these changes
Mar 25, 2022
mdedetrich
force-pushed
the
update-never-terminate-logic
branch
from
aac9a46
to
232d3a9
Compare
jlprat
approved these changes
Mar 25, 2022
reta
reviewed
Mar 25, 2022
|
|
||
| /** Hook that lets the user specify the future that will signal the shutdown of the server whenever completed. Adapted | ||
| * from | ||
| * https://github.com/akka/akka-http/blob/main/akka-http/src/main/scala/akka/http/scaladsl/server/HttpApp.scala#L151-L163 |
reta
approved these changes
Mar 25, 2022
This was referenced Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
The #165 PR didn't completely correctly implement the logic where the CLI backup never terminates.