Log exceptions thrown inside SubFlow #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
log-subflow-exception
branch
from
38eedb0
to
c18c60e
Compare
reta
approved these changes
May 10, 2022
reta
reviewed
May 10, 2022
core-backup/src/main/scala/io/aiven/guardian/kafka/backup/BackupClientInterface.scala
Outdated
Show resolved
Hide resolved
…upClientInterface.scala Co-authored-by: Andriy Redko <drreta@gmail.com>
reta
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Due to an existing limitation with
SubFlow(details in comments in PR), any exceptions that get thrown in theSubFloware suppressed and cause the stream to retry and hence loop indefinitely.References: #221
Why this way
The core problem is not solvable right now (at least without upstream changes) however we can at least log the exception so users know whats going on. This is particularly problematic for silly mistakes such as getting S3 credentials wrong as currently there is no feedback at all.