Use SubstreamStrategy.propagate to complete substream on Exception #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2303442584
💛 - Coveralls |
reta
approved these changes
May 11, 2022
reta
reviewed
May 11, 2022
| case End => true | ||
| case _ => false | ||
| } | ||
| .splitAfter(SubstreamCancelStrategy.propagate) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Turns out it is possible to cancel the parent stream when using a
Subflowwith aSubstreamCancelStrategyResolves: #221
Why this way
The overloaded
.splitAftermethod has aSubstreamCancelStrategyparameter which defaults to.drainIf we use.propagatethen we get the desired behavior however if an exception is thrown we still need to log it sinceSupervisionStategyis still ignored (see upstream akka/akka#31394 for more context)