Wait for materialized value before completing in chunk upload #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Currently in Pekko we ignore the result when a chunk upload sink is uploaded, this PR fixes that.
Why this way
Originally when I wrote the
kafkaBatchSink
I wasn't that familiar with the graphDSL and in its original implementation I didn't pass in thesuccessSink
/failureGraph
into the graph. What this meant is that while the core business logic would run, it wouldn't wait on completion of either thesuccessSink
orfailureSink
.This may also help in the current flakiness of guardian tests.
Also make sure to hide whitespace when viewing the PR, also the PR requires a snapshot version of Pekko connectors due to needing this change apache/pekko-connectors#280