feature: Make schema backup handle empty topics #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
aiven-anton/feature/backup-v3-avro
branch
from
bf3dee0
to
130b9ca
Compare
aiven-anton
force-pushed
the
aiven-anton/feature/backup-v3-avro
branch
6 times, most recently
from
93b006a
to
801a367
Compare
aiven-anton
changed the base branch from
main
to
aiven-anton/feature/backup-v3-avro-verify
aiven-anton
force-pushed
the
aiven-anton/feature/backup-v3-avro-test-restore-empty-topic
branch
from
e16abce
to
8c12eeb
Compare
Deploying with
|
| Latest commit: |
2836bba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://599b5e46.karapace.pages.dev |
| Branch Preview URL: | https://aiven-anton-feature-backup-v-1ql2.karapace.pages.dev |
aiven-anton
force-pushed
the
aiven-anton/feature/backup-v3-avro-verify
branch
2 times, most recently
from
e28ae4b
to
9a9e5e1
Compare
Base automatically changed from
aiven-anton/feature/backup-v3-avro-verify
to
main
May 30, 2023 12:43
aiven-anton
force-pushed
the
aiven-anton/feature/backup-v3-avro-test-restore-empty-topic
branch
2 times, most recently
from
40e0d67
to
d03605c
Compare
giuseppelillo
previously approved these changes
May 30, 2023
- Adds `start_offset` and `end_offset` to data files in `Metadata`. - Adds verification of start and end offset in backup reader. - Adds `record_count` to `Metadata`. - Start sourcing `partition_count` directly from what's read from Kafka, instead of indirectly via `len(data_files)`. - Test can restore empty topics.
aiven-anton
force-pushed
the
aiven-anton/feature/backup-v3-avro-test-restore-empty-topic
branch
from
d03605c
to
2836bba
Compare
giuseppelillo
approved these changes
May 31, 2023
jjaakola-aiven
deleted the
aiven-anton/feature/backup-v3-avro-test-restore-empty-topic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
start_offsetandend_offsetto data files in metadata.record_counttoMetadata.partition_countdirectly from what's read from Kafka, instead of vialen(data_files).