fix: Correctly raise producer exceptions #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
86fac38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b2a9a99.karapace.pages.dev |
| Branch Preview URL: | https://giuseppelillo-fix-producer-e.karapace.pages.dev |
aiven-anton
reviewed
Jun 15, 2023
giuseppelillo
force-pushed
the
giuseppelillo/fix-producer-error
branch
from
2d5ab72
to
18ee1b9
Compare
aiven-anton
reviewed
Jun 15, 2023
karapace/backup/api.py
Outdated
|
|
||
|
|
||
| def _handle_producer_send( | ||
| instruction: ProducerSend, | ||
| producer: KafkaProducer, | ||
| ) -> None: | ||
| check_producer_exception() |
There was a problem hiding this comment.
issue: Let's document (with comment) the reason why we're also doing this here. Is it to reach a stop quicker than waiting for the call in restore_backup()?
There was a problem hiding this comment.
Yes, this call is made here to avoid calling send() for all messages if there was an error earlier.
There was a problem hiding this comment.
This still applies with the new change-set. For a reader of the code, it won't be obvious why the check method is called in two different places. I think it's important to document, with a comment in the code, why we make the post-send call: it's an optimization. And that one of the calls is fundamental for correct behavior, and one is not.
giuseppelillo
force-pushed
the
giuseppelillo/fix-producer-error
branch
from
18ee1b9
to
f2e65a0
Compare
aiven-anton
reviewed
Jun 15, 2023
giuseppelillo
force-pushed
the
giuseppelillo/fix-producer-error
branch
from
f2e65a0
to
eb19aa3
Compare
giuseppelillo
changed the title
aiven-anton
reviewed
Jun 16, 2023
giuseppelillo
force-pushed
the
giuseppelillo/fix-producer-error
branch
3 times, most recently
from
434ea31
to
c51e3a4
Compare
karapace/backup/api.py
Outdated
| _producer_exception = None | ||
|
|
||
| def _producer_error_callback(exception: Exception) -> None: | ||
| LOG.error("Producer error: %r", exception) |
There was a problem hiding this comment.
Suggested change
| LOG.error("Producer error: %r", exception) | |
| LOG.error("Producer error callback", exc_info=exception) |
giuseppelillo
force-pushed
the
giuseppelillo/fix-producer-error
branch
2 times, most recently
from
17d53ed
to
5f7e5e3
Compare
aiven-anton
reviewed
Jun 16, 2023
giuseppelillo
force-pushed
the
giuseppelillo/fix-producer-error
branch
from
5f7e5e3
to
cd43ef6
Compare
jjaakola-aiven
previously approved these changes
Jun 16, 2023
aiven-anton
reviewed
Jun 16, 2023
Fix a bug in which producer exceptions were raised inside the I/O thread instead of the main one.
giuseppelillo
force-pushed
the
giuseppelillo/fix-producer-error
branch
from
cd43ef6
to
86fac38
Compare
jjaakola-aiven
approved these changes
Jun 16, 2023
aiven-anton
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in which producer exceptions were raised inside the I/O thread instead of the main one.