Implement KIP-893 nullable entity fields #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 96.31% 96.69% +0.37%
==========================================
Files 13 14 +1
Lines 951 997 +46
Branches 132 141 +9
==========================================
+ Hits 916 964 +48
+ Misses 30 29 -1
+ Partials 5 4 -1 ☔ View full report in Codecov by Sentry. |
aiven-anton
commented
Nov 21, 2023
aiven-anton
force-pushed
the
aiven-anton/fix-nullable-entity-field
branch
from
0fc4ec6
to
94e1949
Compare
This commit implements support for the nullable entity field introduced in `ConsumerGroupHeartbeatResponse.assignment`. This kind of field was formalized upstream in KIP-893 but is not mentioned in any official documentation of the protocol. The KIP also mentions tagged fields. I left this out for now as I don't understand why another mechanism for omitting a tagged field value is needed, and AFAIK no entity uses this yet.
aiven-anton
force-pushed
the
aiven-anton/fix-nullable-entity-field
branch
from
94e1949
to
04455db
Compare
5 tasks
giuseppelillo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements support for the nullable entity field introduced in
ConsumerGroupHeartbeatResponse.assignment. This kind of field was formalized upstream in KIP-893 but is not mentioned in any official documentation of the protocol.The KIP also mentions tagged fields. I left this out as I don't understand why another mechanism for omiting a tagged field value is needed, and AFAIK no entity uses this yet.
Partially addresses #100.