Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basebackup mode with delta statistics [BF-356] #422

Merged
merged 1 commit into from Apr 27, 2021

Conversation

alexole
Copy link
Contributor

@alexole alexole commented Apr 23, 2021

Add local-tar-delta-stats basebackup mode, which behaves the same as
local-tar mode, but adds some statistics as if it was a delta mode, so
these numbers can be used to support a decision if switching the delta mode
makes sense.

@swarmia
Copy link

swarmia bot commented Apr 23, 2021

@alexole alexole marked this pull request as ready for review April 23, 2021 14:06
@alexole alexole requested review from rikonen and a team April 23, 2021 14:13
Copy link

@janw janw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, apart from suggesting refactoring instead of raising max-module-lines in linter.

.pylintrc Show resolved Hide resolved
Copy link

@dmitry-potepalov dmitry-potepalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment is more or less cosmetic, a more thorough review is needed

pghoard/basebackup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rikonen rikonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation for the new backup mode.

pghoard/basebackup.py Outdated Show resolved Hide resolved
pghoard/basebackup.py Show resolved Hide resolved
pghoard/basebackup.py Outdated Show resolved Hide resolved
@alexole alexole force-pushed the alex-add-delta-stats-to-local-tar-backup branch 3 times, most recently from eeda88c to 543b8c3 Compare April 27, 2021 07:51
Add `local-tar-delta-stats` basebackup mode, which behaves the same as
`local-tar` mode, but adds some statistics as if it was a `delta` mode, so
this numbers can be used to support a decision if switching the delta mode
makes sense.
@alexole alexole force-pushed the alex-add-delta-stats-to-local-tar-backup branch from 543b8c3 to a5b2d60 Compare April 27, 2021 08:14
@alexole alexole requested a review from rikonen April 27, 2021 08:55
@rikonen rikonen merged commit 469e75f into master Apr 27, 2021
@rikonen rikonen deleted the alex-add-delta-stats-to-local-tar-backup branch April 27, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants