New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basebackup mode with delta statistics [BF-356] #422
Conversation
✅ Linked to Story BF-356 · pghoard: local tar backup mode with delta metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, apart from suggesting refactoring instead of raising max-module-lines in linter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comment is more or less cosmetic, a more thorough review is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation for the new backup mode.
eeda88c
to
543b8c3
Compare
Add `local-tar-delta-stats` basebackup mode, which behaves the same as `local-tar` mode, but adds some statistics as if it was a `delta` mode, so this numbers can be used to support a decision if switching the delta mode makes sense.
543b8c3
to
a5b2d60
Compare
Add
local-tar-delta-stats
basebackup mode, which behaves the same aslocal-tar
mode, but adds some statistics as if it was adelta
mode, sothese numbers can be used to support a decision if switching the delta mode
makes sense.