Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pipeline - check major versions only for commands #534

Merged
merged 1 commit into from
May 19, 2022

Conversation

alexole
Copy link
Contributor

@alexole alexole commented May 19, 2022

About this change - What it does

Fixes the CI pipeline

Why this way

In the tests we check the full versions of the PG binaries used, some packages are shipped with different minor versions of binaries (not necessarily the latest), so we should check major version only, they should be compatible.

@alexole alexole requested review from a team as code owners May 19, 2022 07:12
Copy link
Contributor

@rdunklau rdunklau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we don't test against 9.6 anymore, this looks like a good idea.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #534 (292dc52) into main (af2a914) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   89.39%   89.42%   +0.02%     
==========================================
  Files          29       29              
  Lines        4490     4490              
==========================================
+ Hits         4014     4015       +1     
+ Misses        476      475       -1     
Impacted Files Coverage Δ
pghoard/pghoard.py 82.79% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa986e...292dc52. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants