Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use synchronous_commit to off #116

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Use synchronous_commit to off #116

merged 1 commit into from
Feb 5, 2024

Conversation

rdunklau
Copy link
Contributor

@rdunklau rdunklau commented Feb 2, 2024

Since txid_current() can block when using synchronous replication, disable synchronous_commit at all.
We only care about generating a new xid to make sure that WAL is progressing, not that it makes its way to the standby.

Since txid_current() can block when using synchronous replication,
disable synchronous_commit at all.
We only care about generating a new xid to make sure that WAL is
progressing, not that it makes it way to the standby.
Copy link
Contributor

@alexole alexole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexole alexole merged commit 5c6f31f into main Feb 5, 2024
21 checks passed
@alexole alexole deleted the turn_synchronous_commit_off branch February 5, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants