Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different DCO action implementation #210

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

lukas-vlcek
Copy link
Collaborator

Switching from https://github.com/tim-actions/dco to https://github.com/tisonkun/actions-dco. While both implementations look very similar there are some differences:

  • The later implementation does not require use of additional action to pull PR commits because it does not rely on commits being setup in core context.
  • The later implementation is explicit about its LICENSE (AL2).

Description

Describe your PR and add links to relevant issues.


  • All my commits include DCO.
    DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using -s option when doing git commit).
    Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.

Switching from <https://github.com/tim-actions/dco> to <https://github.com/tisonkun/actions-dco>.
While both implementations look very similar there are some differences:

- The later implementation does not require use of additional action to pull PR commits because
it does not rely on `commits` being setup in `core` context.
- The later implementation is explicit about its LICENSE (AL2).

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@lukas-vlcek lukas-vlcek merged commit 81274dd into Aiven-Open:main Aug 9, 2023
2 checks passed
@lukas-vlcek lukas-vlcek deleted the update_dco_action branch August 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant