Skip to content

Commit

Permalink
object_storage: make bucket_name optional
Browse files Browse the repository at this point in the history
For some object storage operations bucket name is not required (for
listing bucket for example).
  • Loading branch information
Roman Inflianskas committed Aug 24, 2023
1 parent 0de7fe9 commit 0e8c61e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions rohmu/object_storage/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def calculate_s3_chunk_size() -> int:


class AzureObjectStorageConfig(StorageModel):
bucket_name: str
bucket_name: Optional[str]
account_name: str
account_key: Optional[str] = Field(None, repr=False)
sas_token: Optional[str] = Field(None, repr=False)
Expand All @@ -89,7 +89,7 @@ class AzureObjectStorageConfig(StorageModel):

class GoogleObjectStorageConfig(StorageModel):
project_id: str
bucket_name: str
bucket_name: Optional[str]
credential_file: Optional[FilePath] = None
credentials: Optional[Dict[str, Any]] = Field(None, repr=False)
proxy_info: Optional[ProxyInfo] = None
Expand All @@ -112,7 +112,7 @@ class S3AddressingStyle(Enum):

class S3ObjectStorageConfig(StorageModel):
region: str
bucket_name: str
bucket_name: Optional[str]
aws_access_key_id: Optional[str] = None
aws_secret_access_key: Optional[str] = Field(None, repr=False)
prefix: Optional[str] = None
Expand Down

0 comments on commit 0e8c61e

Please sign in to comment.