Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play nice with vocab builder plugin #22

Closed
equwal opened this issue May 3, 2024 · 4 comments
Closed

Play nice with vocab builder plugin #22

equwal opened this issue May 3, 2024 · 4 comments

Comments

@equwal
Copy link

equwal commented May 3, 2024

Looks like this plugin and vocab builder conflict because they both try to set the same button, rather than creating two buttons for example.

@nairyosangha
Copy link
Member

I'm not sure this is going to be possible. KOReader provides a tweak_buttons_func which is called by the widget that shows the dictionary when you do a lookup. This was added specifically for the vocabbuilder plugin. I'm using the same thing, and I make sure that it gets overwritten when the reader is loaded, while vocabbuilder only calls it on startup.

Because of that, I overwrite the function set by vocabbuilder. It's not really designed in a way to be called in multiple places

@equwal
Copy link
Author

equwal commented May 11, 2024

ok then

@equwal equwal closed this as completed May 11, 2024
Frenzie pushed a commit to koreader/koreader that referenced this issue May 16, 2024
@nairyosangha
Copy link
Member

The guys at koreader were nice enough to allow me to make this work for me, so I can actually do this properly now after all, but I will wait for a new koreader release first

@nairyosangha
Copy link
Member

New koreader release is out, this should no longer be a problem now (be sure to check out the latest commit here too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants