[2.1] Field names Addition #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added minimal and maximal length for sentences
- Updated field names to match standard sub2srs format - Remove Audio and image caption - Add tags to view
- Add buttons - Change behaviour of note count
- map needed as list for indexing - setting the page buttons and page was not yet done
Sync with main
remove unused methods
|
There's extra code that is not related to this PR, so it is difficult to tell what to merge and what to discard. I'll try to figure it out though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added presets for the setting of the names.
Should have noticed this before, sorry