Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler double quote replacement #107

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

artjomsR
Copy link
Contributor

@artjomsR artjomsR commented Sep 5, 2023

What drove me to submit this PR was the fact that double quotes were still copied as \" which made for unappealing and distracting looking cards. 2 apostrophes in a row look very similar so it's still visually pleasing and avoids issues with escaping double quotes

@tatsumoto-ren
Copy link
Member

Is it possible to use " instead? Or, possibly, and ?

@artjomsR
Copy link
Contributor Author

artjomsR commented Sep 5, 2023

Good idea, I'll try that for some time and update the PR later

@artjomsR
Copy link
Contributor Author

I've updated the PR - didn't figure out how best to use " easily around all the use cases but looks nice and is simple so I just went with that

@tatsumoto-ren
Copy link
Member

Alright

@tatsumoto-ren tatsumoto-ren merged commit b4f0dfe into Ajatt-Tools:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants