Add RTL support to input field and messages #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is using the `dir=auto` algorithm in addition to `text-align: justify` to correct the global `text-align: left` that applies to this text field. Tested with inspector, hoping that's not out of the standard for this project.
yarons
commented
May 16, 2021
| @@ -179,6 +179,8 @@ | |||
| } | |||
|
|
|||
| #editable-message-text { | |||
| text-align: justify; | |||
| direction: auto; | |||
There was a problem hiding this comment.
This is incorrect, I'm fixing that, sorry about that.
direction: auto isn't a thing appearently.
Same as master but now in the correct branch.
|
Just wanted to mention that the time label (in the bottom right corner) is now covered by the text, I'm not sure it's possible to fix it with the same css properties but I'll try. |
yarons
changed the title
|
Hi @yarons! Thanks for your contribution, we are testing this solution on our side. |
|
Thank you so much, I've tested webk implementation and it works better than mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using the
dir=autoalgorithm in addition totext-align: justifyto correct the globaltext-align: leftthat applies to this text field.Tested with inspector, hoping that's not out of the standard for this project.
Fixing the smaller problem mentioned in #12.