Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #110 #123

Merged
merged 4 commits into from
Mar 2, 2024
Merged

Fixes #110 #123

merged 4 commits into from
Mar 2, 2024

Conversation

VishnuSanal
Copy link
Contributor

@VishnuSanal VishnuSanal commented Feb 29, 2024 •
edited

Fixes #110

@AkaneTan
Copy link
Owner

AkaneTan commented Mar 1, 2024

Gramophone/app/src/main/kotlin/org/akanework/gramophone/ui/components/GridPaddingDecoration.kt

Line 13 in ccb1b1d

private var mPadding = 10.dpToPx(context)

This is what changes the side space of grid layout, simply adding margin won't do the trick

@VishnuSanal VishnuSanal changed the base branch from beta to beta-sbl March 1, 2024 15:27
@VishnuSanal VishnuSanal changed the base branch from beta-sbl to beta March 1, 2024 15:27
@nift4 nift4 merged commit 0ebf936 into AkaneTan:beta Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Milestone] Fix inconsistent space on both sides of grid layout recyclerview
3 participants
@VishnuSanal @AkaneTan @nift4