Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNX120 Decoding is broken #3

Closed
kedaitinh12 opened this issue Jun 5, 2021 · 22 comments
Closed

DNX120 Decoding is broken #3

kedaitinh12 opened this issue Jun 5, 2021 · 22 comments
Labels
video video related

Comments

@kedaitinh12
Copy link

I seen new issues after HolyWu archived repository here:
https://forum.doom9.org/showthread.php?p=1943308#post1943308

Please can you fix it???

@AkarinVS
Copy link
Owner

Thanks for reporting this. I'm not familiar with DNX120.

I will see what the ffms2 developers come up with their FFMS/ffms2#384 and then perhaps I can incorporate it here.
Also the corresponding ffmpeg issue: https://trac.ffmpeg.org/ticket/9255.

Perhaps upstream ffmpeg will fix this issue and we just need to wait for the next release.

@AkarinVS AkarinVS changed the title New issues after HolyWu archived repository DNX120 Decoding is broken Jul 13, 2021
@kedaitinh12
Copy link
Author

Thanks, can you update for avisynth too??

@AkarinVS
Copy link
Owner

AkarinVS commented Jul 14, 2021 via email

@kedaitinh12
Copy link
Author

Wow, thanks very much

@FranceBB
Copy link

Great!
On the other hand, nobody replied to me in the ffmpeg bugtracker any longer, so... shall we try to storm it up a little bit? I mean, get more people from Doom9 to here https://trac.ffmpeg.org/ticket/9255 trying to get them to fix it?

@FranceBB
Copy link

Besides, it's not just that one, also this one is a bug: https://forum.doom9.org/showthread.php?s=99240aeff3923b4183491c781f9014e2&p=1942428

and I opened the relative FFMpeg bug in their tracker, but again, no reply from them whatsoever: https://trac.ffmpeg.org/ticket/9219

however in this case I provided a working solution for FFMpeg that can be used by users, therefore I would suggest to implement the logic (if possible) in LWLibavAudioSource() to detect if it's an IPCM and not a standard PCM and append the relative codec info before calling the decoder, namely: -c:a pcm_s24be

Is something like this doable in the LSMASH Source code?

@kedaitinh12
Copy link
Author

@AkarinVS I seen you updated for avisynth. Thanks but you can update for x86 too?? Cause in avisynth many people still use x86 ver

@AkarinVS
Copy link
Owner

AkarinVS commented Jul 19, 2021 via email

@kedaitinh12
Copy link
Author

Ok, i will test

@kedaitinh12
Copy link
Author

I am getting this error message: "Script error: There is no function named 'LWLibavVideoSource'"

@qyot27
Copy link

qyot27 commented Jul 20, 2021

For C++ plugins to work in the standard builds of AviSynth+, you have to use the MSVC solution (or at least point meson at cl.exe and such).

The meson file in the AviSynth directory is for Linux, macOS, etc., where there aren't competing C++ compilers with incompatible name mangling and such.

It would (and does) work if AviSynth+ was built with GCC, like this test build I'd provided a couple years ago:
https://www.mediafire.com/file/s88qcoqcp108a0a/avisynth%252B-gcc_r2831-g316b54aa-20190321.7z/file

But g++-built AviSynth+ can't load MSVC-built C++ plugins, just like MSVC-built AviSynth+ can't load g++-built plugins.

@AkarinVS
Copy link
Owner

AkarinVS commented Jul 20, 2021 via email

@realfinder
Copy link

realfinder commented Jul 23, 2021

or just use c api of AviSynth/AviSynth+ same as Asd-g/AviSynth-VMAF@5c1a5e0

@AkarinVS AkarinVS added the video video related label Jul 29, 2021
@AkarinVS
Copy link
Owner

AkarinVS commented Jul 29, 2021 via email

@kedaitinh12
Copy link
Author

Asd-g now fixed for DNXHD
HomeOfAviSynthPlusEvolution/L-SMASH-Works@e5bb1ec

@kedaitinh12
Copy link
Author

Thanks for your L-SMASH Works updated @AkarinVS

@kedaitinh12
Copy link
Author

And your new commit HomeOfAviSynthPlusEvolution/L-SMASH-Works@d36219a

Give error in avisynth
HomeOfAviSynthPlusEvolution/L-SMASH-Works#6

I don't know if this have same error in vs??

@AkarinVS
Copy link
Owner

@kedaitinh12 fixed.

@AkarinVS
Copy link
Owner

This issue is not yet fixed (applying HomeOfAviSynthPlusEvolution/L-SMASH-Works@e5bb1ec breaks reading the attached sample files.)

@AkarinVS AkarinVS reopened this Jul 30, 2021
@FranceBB
Copy link

Fixed by ASD-G. See here: HomeOfAviSynthPlusEvolution/L-SMASH-Works@e5bb1ec

@AkarinVS
Copy link
Owner

Thanks for the reminder. I have applied the FFmpeg patch and it should be picked up in the next release.

@kedaitinh12
Copy link
Author

kedaitinh12 commented Aug 11, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
video video related
Projects
None yet
Development

No branches or pull requests

5 participants