Skip to content

Commit

Permalink
service - compare version without LooseVersion (ansible#74508)
Browse files Browse the repository at this point in the history
The distutils module is not shipped with SUNWPython on Solaris.
It's in the SUNWPython-devel package. Do not use LooseVersion.

Fixes: ansible#74488

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
  • Loading branch information
Akasurde committed May 7, 2021
1 parent a277644 commit 4d7dc15
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/74488_solaris_looseversion.yml
@@ -0,0 +1,2 @@
bugfixes:
- service - compare version without LooseVersion API (https://github.com/ansible/ansible/issues/74488).
4 changes: 2 additions & 2 deletions lib/ansible/modules/service.py
Expand Up @@ -1355,8 +1355,8 @@ def svcadm_supports_sync(self):
# Support for synchronous restart/refresh is only supported on
# Oracle Solaris >= 11.2
for line in open('/etc/release', 'r').readlines():
m = re.match(r'\s+Oracle Solaris (\d+\.\d+).*', line.rstrip())
if m and LooseVersion(m.groups()[0]) >= LooseVersion('11.2'):
m = re.match(r'\s+Oracle Solaris (\d+)\.(\d+).*', line.rstrip())
if m and m.groups() >= ('11', '2'):
return True

def get_service_status(self):
Expand Down

0 comments on commit 4d7dc15

Please sign in to comment.