Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python webserver use unbuffered IO. #43

Closed
wants to merge 1 commit into from

Conversation

telnoratti
Copy link

When using the oauth functionality of gdl, I discovered a bug that made "$TMPFILE.code" always be an empty file. It seems that python was buffering output to the file and so the log would never be written to it. I added the -u flag to python which forced IO to be unbuffered and resolved the issue for me. The change passed the tests, but it wasn't clear the oauth component was tested.

As a side note some systems have python 2 and python 3 installed, but python is python 2. If python 3 is on a system, my understanding is that python3 should always be that.

@Akianonymus
Copy link
Owner

I don't know why it has empty file, weird as it was working for me. Given that the server is unbuffered, even then there should be no problem as the python server closes just after one request.

But anyway, this will be merged.

Push another commit and change python to python3

@Akianonymus
Copy link
Owner

I pushed the changes my self and authored you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants