Make python webserver use unbuffered IO. #43
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the oauth functionality of gdl, I discovered a bug that made "$TMPFILE.code" always be an empty file. It seems that python was buffering output to the file and so the log would never be written to it. I added the
-u
flag to python which forced IO to be unbuffered and resolved the issue for me. The change passed the tests, but it wasn't clear the oauth component was tested.As a side note some systems have python 2 and python 3 installed, but python is python 2. If python 3 is on a system, my understanding is that
python3
should always be that.