added bug fix for unregistered event listener

AkinAguda · Jun 18, 2021 · 937c588 · 937c588
1 parent 86beaaf
commit 937c588
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,5 +1,5 @@
 {
-  "version": "0.2.0",
+  "version": "0.2.1",
   "license": "MIT",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

diff --git a/src/index.tsx b/src/index.tsx
@@ -38,27 +38,28 @@ const UnopDropdown: React.FC<UnopDropdownProps> = ({
     element.style.visibility = 'visible';
   }, []);
 
+  const handler = (e: MouseEvent) => {
+    const path = e.composedPath();
+    if (show && closeOnClickOut && !path.includes(dropdownMenuRef.current!)) {
+      handleAction(e);
+    } else {
+      if (
+        show &&
+        closeOnDropdownClicked &&
+        path.includes(dropdownMenuRef.current!)
+      ) {
+        handleAction(e);
+      }
+    }
+  };
+
   useEffect(() => {
     if (closeOnClickOut || closeOnDropdownClicked) {
-      window.addEventListener('click', (e) => {
-        const path = e.composedPath();
-        if (
-          show &&
-          closeOnClickOut &&
-          !path.includes(dropdownMenuRef.current!)
-        ) {
-          handleAction(e);
-        } else {
-          if (
-            show &&
-            closeOnDropdownClicked &&
-            path.includes(dropdownMenuRef.current!)
-          ) {
-            handleAction(e);
-          }
-        }
-      });
+      window.addEventListener('click', handler);
     }
+    return () => {
+      window.removeEventListener('click', handler);
+    };
   }, [show]);
 
   const displayMenuItem = (e: CustomMouseEvent) => {