Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to 'Top-level declarations' error #462

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Conversation

cristianireyes
Copy link

@cristianireyes cristianireyes commented Jan 25, 2020

Solution to the error:
3:1 Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

Issue: #459

@chindit
Copy link

chindit commented Feb 3, 2020

Tested and working. 👍

Thanks @cristianireyes

@naughtLdy
Copy link

naughtLdy commented Feb 4, 2020

I think, it is good solution.
But, this type definition is not represent reality.

Here is more better defintion.
naughtLdy@a73aab0

@chindit
Copy link

chindit commented Feb 10, 2020

Feel free to create a PR @naughtLdy

But now, we're just waiting for a maitainer to give his opinion on this.

@cristianireyes cristianireyes changed the title Fix #459 Fix to #459 - Top-level declarations error Feb 14, 2020
@cristianireyes cristianireyes changed the title Fix to #459 - Top-level declarations error Fix to 'Top-level declarations' error Feb 14, 2020
@abrad
Copy link

abrad commented Feb 18, 2020

+1 for needing this fix! Thanks for the work

@bjufre
Copy link

bjufre commented Feb 24, 2020

@Akryum is there any ETA as to when this is gonna get merged? Thank you!

@janpansa
Copy link

janpansa commented Mar 6, 2020

@Akryum Also waiting for this. Thank you for the work !

@alanaasmaa
Copy link

Downgrading to @2.0.2 resolves the error.

@Peter-Barrett
Copy link

@Akryum just coming across this issue now, having this PR merged would be much appreciated. Thanks.

@undergroundwires
Copy link

Is this repository still maintained? @Akryum please take a look a this.

@Akryum Akryum merged commit 1bebd14 into Akryum:master Dec 30, 2020
@Akryum Akryum mentioned this pull request Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants