Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandboxDarkClass does not work when using grid layout #442

Closed
6 tasks done
valgeirb opened this issue Feb 9, 2023 · 0 comments
Closed
6 tasks done

sandboxDarkClass does not work when using grid layout #442

valgeirb opened this issue Feb 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@valgeirb
Copy link

valgeirb commented Feb 9, 2023

Describe the bug

According to this comment, an iframe is not used when using a grid layout. The problem is that then the sandboxDarkClass won't get toggled.

This makes using the grid layout impossible if you want to show dark versions of your components.

Reproduction

Define a dark class for easier debugging:

defineConfig({
  sandboxDarkClass: 'my-dark-class',
})

Notice that the class does not get added when using a grid layout.

System Info

System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 1011.77 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.volta/tools/image/node/16.14.2/bin/node
    Yarn: 1.22.18 - ~/.volta/tools/image/yarn/1.22.18/bin/yarn
    npm: 8.5.0 - ~/.volta/tools/image/node/16.14.2/bin/npm
  Browsers:
    Chrome: 109.0.5414.119
    Firefox: 107.0.1
    Safari: 16.2
  npmPackages:
    @histoire/plugin-vue: ^0.13.2 => 0.13.2 
    @vitejs/plugin-vue: ^4.0.0 => 4.0.0 
    histoire: ^0.13.2 => 0.13.2 
    vite: ^4.0.4 => 4.0.4

Used Package Manager

npm

Validations

@valgeirb valgeirb added the to triage This issue needs to be triaged label Feb 9, 2023
@Akryum Akryum added bug Something isn't working and removed to triage This issue needs to be triaged labels Feb 10, 2023
@Akryum Akryum closed this as completed in 6ea5bbe Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants