feat(screenshot): add launchOptionsArgs to be able to pass args for c… #446
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kdnk
force-pushed
the
main
branch
2 times, most recently
from
8aa251b
to
75efb1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add capabilities to pass some args for
captureWebsite(andPuppeteer).Additional context
Puppeteer has a
launchOptions, and we can pass them through caputre-website. https://github.com/sindresorhus/capture-website#im-getting-a-sandbox-related-error.This
launchOptionsoption is helpful if we have sandbox-related issues (mainly inside Docker).But now, we cannot configure them via Histoire.
https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#setting-up-chrome-linux-sandbox
https://github.com/sindresorhus/capture-website#im-getting-a-sandbox-related-error
reg-viz/storycap#23
reg-viz/storycap#495
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).[ ] Ideally, include relevant tests that fail without this PR but pass with it.not test for screenshot.