Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svelte): Supplement missing member types #483

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Conversation

fw6
Copy link
Contributor

@fw6 fw6 commented Mar 14, 2023

Add step prop types for Number and Slider controls

image

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Add step prop types for Number and Slider controls
@codesandbox
Copy link

codesandbox bot commented Mar 14, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@stackblitz
Copy link

stackblitz bot commented Mar 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 0afeb5f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/641385e49229f6000729da97
😎 Deploy Preview https://deploy-preview-483--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 0afeb5f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/641385e4016f8e00087002e4
😎 Deploy Preview https://deploy-preview-483--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 0afeb5f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/641385e4efaa960008b52ccd
😎 Deploy Preview https://deploy-preview-483--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 0afeb5f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/641385e4422cba00083b4ce2
😎 Deploy Preview https://deploy-preview-483--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Akryum Akryum merged commit b99ce84 into histoire-dev:main Mar 16, 2023
@fw6 fw6 deleted the patch-1 branch March 17, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants