fix(nuxt): pass nuxt runtimeConfig into nuxt app stub (fix #494) #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
|
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
epr3
changed the title
epr3
changed the title
Akryum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #494
I've made the setupNuxtApp function to accept the current Nuxt instance's public runtime config that is returned from loadNuxt and also passed in that value into setupCode in an 'eval' like fashion through JSON.stringify.
Additional context
This should address the issue at hand, but may also fix compatibility issues with other Nuxt modules which may populate the public runtime config as part of their initialisation such as @storyblok/nuxt (I've encountered this issue on another project while attempting to integrate Histoire).
Relevant line: https://github.com/storyblok/storyblok-nuxt/blob/8874551fa331c72921cd4a8279c67089311c5750/src/module.ts#L57
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).