Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svelte): add svelte@^4.0.0 peer dependency option for svelte plugin (fix #551) #569

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

specialdoom
Copy link
Contributor

@specialdoom specialdoom commented Aug 2, 2023

Description

Fixes #551.

I've added version ^4.0.0 for the peer dependency inside the svelte histoire plugin to be able to migrate the existing repositories that are using histoire with svelte to latest version (^4.0.0).

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Aug 2, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 9e17941
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/64d8d966f980190008bf5f46
😎 Deploy Preview https://deploy-preview-569--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 9e17941
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/64d8d966b8f1bd00089de030
😎 Deploy Preview https://deploy-preview-569--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 9e17941
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/64d8d96775ee21000888f2ab
😎 Deploy Preview https://deploy-preview-569--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 9e17941
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/64d8d9674f54650008a5f643
😎 Deploy Preview https://deploy-preview-569--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@specialdoom specialdoom marked this pull request as ready for review August 2, 2023 11:40
@swyxio
Copy link

swyxio commented Aug 13, 2023

@bluwy strong recommend for merging this one in pls as it is unnecessarily causing histoire to look broken for svelte 4

@specialdoom
Copy link
Contributor Author

I'll try to fix the conflicts and ping a maintainer. Would be great to have a review and some guidance.

@Akryum Akryum changed the title fix: add svelte@^4.0.0 peer dependency option for svelte plugin (fix #551) fix(svelte): add svelte@^4.0.0 peer dependency option for svelte plugin (fix #551) Aug 13, 2023
@Akryum Akryum merged commit 1dac9be into histoire-dev:main Aug 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@histoire/plugin-svelte: Peer Dependency "svelte": "^3.0.0" prevents installation of svelte 4
4 participants