Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): don't stub out unenv #578

Merged
merged 3 commits into from
Aug 15, 2023
Merged

fix(nuxt): don't stub out unenv #578

merged 3 commits into from
Aug 15, 2023

Conversation

danielroe
Copy link
Collaborator

@danielroe danielroe commented Aug 15, 2023

Description

In preparation for upcoming h3 1.8.0 release, this removes the unenv stub that we currently have in histoire. There may be some extra context I'm unaware of though in #443 for why this is present. (I'm hoping the underlying reason has been addressed/resolved upstream since then.)

I'm including h3-nightly in deps to confirm (in CI) that this resolves the underlying issue; I'll remove before marking ready to merge.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@danielroe danielroe self-assigned this Aug 15, 2023
@codesandbox
Copy link

codesandbox bot commented Aug 15, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@stackblitz
Copy link

stackblitz bot commented Aug 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 4ea9410
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/64db38093030ee000951cb6d
😎 Deploy Preview https://deploy-preview-578--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 4ea9410
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/64db3809d5796b00087e19b0
😎 Deploy Preview https://deploy-preview-578--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 4ea9410
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/64db3809d12ee400087c4086
😎 Deploy Preview https://deploy-preview-578--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 4ea9410
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/64db3809a106fd00089b3f2f
😎 Deploy Preview https://deploy-preview-578--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielroe danielroe marked this pull request as draft August 15, 2023 08:20
@danielroe danielroe marked this pull request as ready for review August 15, 2023 08:32
@danielroe danielroe requested a review from Akryum August 15, 2023 08:38
@Akryum Akryum merged commit 7a29c39 into main Aug 15, 2023
20 of 22 checks passed
@Akryum Akryum deleted the fix/unenv branch August 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants