Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tailwind): allow different fontSize configuration values #580

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

czondi
Copy link
Contributor

@czondi czondi commented Aug 15, 2023

Description

Fixes an issue where only one type of value is allowed for configuring fontSize in the Tailwind theme. Tailwind supports the following values:

module.exports = {
  theme: {
    fontSize: {
      sm: '0.8rem', // single value
      base: ['16px', '24px'], // [fontSize, lineHeight] tuple
      'lg': ['1.5rem', {
        lineHeight: '2rem',
        letterSpacing: '-0.01em',
        fontWeight: '500',
      }], // [fontSize, { lineHeight?, letterSpacing?, fontWeight? }] tuple
    }
  }
}

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@codesandbox
Copy link

codesandbox bot commented Aug 15, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 78c92c0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/64db82981abafc0007b543ff
😎 Deploy Preview https://deploy-preview-580--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 78c92c0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/64db8297d12ee40008872cd3
😎 Deploy Preview https://deploy-preview-580--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 78c92c0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/64db8297baa7bd00088d4e23
😎 Deploy Preview https://deploy-preview-580--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 78c92c0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/64db8297de51a40008eaae31
😎 Deploy Preview https://deploy-preview-580--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akryum Akryum changed the title fix(tailwind tokens): allow different fontSize configuration values fix(tailwind): allow different fontSize configuration values Aug 15, 2023
@Akryum Akryum merged commit 942d503 into histoire-dev:main Aug 15, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to set an indexed property on 'CSSStyleDeclaration' (FontSize/TailwindCSS)
2 participants