You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix histoire not starting on Windows because of a infinite loop in findUp function.
in find-up.ts, on Windows on the drive C:, root is equal to "C:" but dir can't be equal to "C:", it can be "C:/" or "/" or something else, so the condition of the loop will always be true, causing an infinite loop.
What is the purpose of this pull request?
Bug fix
New Feature
Documentation update
Other
Before submitting the PR, please make sure you do the following
If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
Hi @Mobyrr , I think this is not a solution. The previous version (0.2.0) of pathe lib had this issue on Windows, but the latest version 1.1.1 is working fine, and there is no such trick is needed anymore: unjs/pathe#5
However I believe the problem might be that pathe has been updated only in the histoire package, but not in the other packages - I'd start by updating the dependencies there first, and check whether it is working on Windows.
Hi @Mobyrr , I think this is not a solution. The previous version (0.2.0) of pathe lib had this issue on Windows, but the latest version 1.1.1 is working fine, and there is no such trick is needed anymore: unjs/pathe#5
However I believe the problem might be that pathe has been updated only in the histoire package, but not in the other packages - I'd start by updating the dependencies there first, and check whether it is working on Windows.
It's not the same issue
If you read the code, with the version 0.2.0, the root was equal to a empty string, now it's "C:" thanks to 1.1.1, but path.dirname can't return "C:", it returns "C:/" when we get at the root, it's all about a missing slash
My fix simply adds the missing slash when root corresponds to a windows root
Also I don't think it's a problem with non-updated dependencies in other packages, I observed with a debugger that it's only this file that causes the problem on Windows
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix histoire not starting on Windows because of a infinite loop in findUp function.
in find-up.ts, on Windows on the drive C:,
rootis equal to "C:" butdircan't be equal to "C:", it can be "C:/" or "/" or something else, so the condition of the loop will always be true, causing an infinite loop.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).