fix: issue 426, add mock ResizeObserver to dom #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mock ResizeObserver to DOM after jsdom initialization to fix issue #426
Additional context
Using the
@formkit/autoanimatemodule makes stories fail on load, since ResizeObserver is missing. The lib itself diligently checks if there is a window object available, before it tries to use it. I checked the relevant issue in Jsdom project ( jsdom/jsdom#3368 ), but most use cases there seemed to be with testing. For those cases, it makes sense to add your own mock, if you want to triggerobservein a test. For us, however, it seems a simple noop replacement will do the trick. Hence this PRWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).