fix(build): use meteor node command instead of node
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See this issue: disney/meteor-base#129
|
It worked with my Meteor + Vue app
Everything is running well in the production environment. Thanks soooo much for this PR. @Akryum could you help us with this fix, please? I also tested the build in my local machine and it still works with this change. Notes:
|
diavrank
approved these changes
Feb 4, 2023
|
@diavrank , did you have to do anything special to make Vite 4 work? |
|
@red-meadow no really, everything kept the same. This is the commit diavrank/theory-swe@79016e7 |
|
@Akryum could you help us with this, please? |
Akryum
changed the title
meteor node command instead of nodemeteor node command instead of node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18 and this one.
This PR replaces
node XXXcommand withmeteor node XXXinvite-bundler/build.js, as described in this comment.This is a small but very critical fix for those using meteor-base docker image. The building is not possible without it. @Akryum , please review it, it's just 2 lines.